Mercurial > addons > firefox-addons > open-incognito

changeset 3:89239e60d9e1 default tip

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Enable on privileged pages There are contexts in Firefox (for example, the default new tab page) that contain links to http(s) resources but are considered privileged. In these contexts `menus.onShown` does not provide the link URL to the extension and Open Incognito disables the context menu entry. However, if the entry is not disabled, the `onClicked` listener will actually know the link URL because a user's click on the extension's menu item is considered to be an explicit permission, so Open Incognito could work. Keep the menu item enabled if the URL is not available. There is a drawback that the item will be enabled but do nothing if the actual link has an unknown/unsupported protocol, but this is probably a more rare situation.
author Denis Lisov <dennis.lissov@gmail.com>
date Sat, 09 Feb 2019 03:38:05 +0300
parents 0e8c61f3373d
children
files background.js
diffstat 1 files changed, 10 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/background.js	Fri Dec 14 22:18:02 2018 +0100
+++ b/background.js	Sat Feb 09 03:38:05 2019 +0300
@@ -8,17 +8,23 @@
 
 'use strict';
 
+function hasKnownProtocol(link) {
+    return (link.startsWith('http:') ||
+            link.startsWith('https:') ||
+            link.startsWith('ftp:'));
+}
+
 function onMenuShown(info, tab) {
     let enabled = !tab.incognito &&
-            typeof info.linkUrl !== 'undefined' &&
-            (info.linkUrl.startsWith('http:') ||
-            info.linkUrl.startsWith('https:') ||
-            info.linkUrl.startsWith('ftp:'));
+            (typeof info.linkUrl === 'undefined' || hasKnownProtocol(info.linkUrl));
     browser.menus.update('open-link-in-private-mode', {enabled});
     browser.menus.refresh();
 }
 
 async function onClicked(info, tab) {
+    if(!hasKnownProtocol(info.linkUrl)) {
+        return;
+    }
     let activeTabs = await browser.tabs.query({
         active: true,
         currentWindow: false,