Mercurial > addons > firefox-addons > feed-preview
view content_scripts/feed-readers.js @ 54:ede87e1004f9
Fix issues with feed detection
Query the feed probe content script for available feeds from the background
script instead of making the content script message the background script.
This solves a race condition between the message from the content script
sending any feeds associated with the current document and the tab's status
"complete" event signaling that a new document has been loaded and hiding
the page action. Sometimes that event would be triggered after the message
from the content script and thus hide the page action again. In addition,
navigating back to a previously visited page might not cause a reload which
means that the content script would not send a message if there were feeds
associated with the current document.
author | Guido Berhoerster <guido+feed-preview@berhoerster.name> |
---|---|
date | Thu, 26 Sep 2019 23:11:18 +0200 |
parents | ff5e5e3eba32 |
children |
line wrap: on
line source
/* * Copyright (C) 2018 Guido Berhoerster <guido+feed-preview@berhoerster.name> * * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 'use strict'; function updateFeedReaders(feedReaders) { let feedReaderSelectionElement = document.forms['feed-subscription'] .elements['feed-reader-selection']; for (let optionElement of feedReaderSelectionElement.querySelectorAll('option')) { optionElement.remove(); } for (let feedReader of feedReaders) { let optionElement = document.createElement('option'); optionElement.value = feedReader.urlTemplate; optionElement.textContent = feedReader.title; feedReaderSelectionElement.append(optionElement); } document.forms['feed-subscription'].elements['main'].disabled = feedReaders.length === 0; } document.addEventListener('submit', ev => { if (ev.target.id !== 'feed-subscription') { return; } ev.preventDefault(); let subscribeUrl = ev.target.elements['feed-reader-selection'].value .replace('%s', encodeURIComponent(document.documentURI)); console.log(`subscribing to feed using ${subscribeUrl}`); window.location.href = subscribeUrl; }); function onStorageChanged(changes, areaName) { if (areaName !== 'sync' || changes.feedReaders === 'undefined') { return; } // stored feed readers have been changed or deleted let feedReaders = typeof changes.feedReaders.newValue !== 'undefined' ? changes.feedReaders.newValue : []; console.log('feedReaders changed to', feedReaders); updateFeedReaders(feedReaders); } (async () => { // initialize subscription form let {feedReaders = []} = await browser.storage.sync.get('feedReaders'); updateFeedReaders(feedReaders); browser.storage.onChanged.addListener(onStorageChanged); })();